Skip to content

test: expand coverage and add bug fix test #2103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

test: expand coverage and add bug fix test #2103

wants to merge 7 commits into from

Conversation

RyanJWard
Copy link
Contributor

@RyanJWard RyanJWard commented Jul 11, 2025 •
edited
Loading

Description

Added tests for product_instance.py and launcher.py using monkeypatch to avoid launching anything.
Also added a bug fix test for a server side change dealing with inserted file id's

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have added the minimum version decorator to any new backend method implemented.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: extrude circle to cylinder)

@RyanJWard RyanJWard self-assigned this Jul 11, 2025
@github-actions github-actions bot added the testing Anything related to tests label Jul 11, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.12%. Comparing base (bfa184d) to head (f42d5b4).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
- Coverage   93.50%   93.12%   -0.38%     
==========================================
  Files         138      138              
  Lines       10156    10156              
==========================================
- Hits         9496     9458      -38     
- Misses        660      698      +38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RyanJWard RyanJWard marked this pull request as ready for review July 11, 2025 17:12
@RyanJWard RyanJWard requested a review from a team as a code owner July 11, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@RyanJWard RyanJWard

Labels
testing Anything related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RyanJWard @pyansys-ci-bot